-
Notifications
You must be signed in to change notification settings - Fork 126
Add first pass of binutils building workflow. #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable building of tests Disable Firestore (to avoid Firestore issues temporarily) Enable Fake secure storage (prevents errors on certain unit tests dealing with secure storage) Add "Debug" config (to catch any unit tests issues in both Release and Debug)
When running all our tests, these LevelDB tests were not running and were causing the testing process to fail, marking these tests as "Not run". Since they are just testing LevelDB, these issues will be caught downstream in our firebase cpp unit tests anyway.
Death tests that are depending on an assert statement to cause a crash fail in Release mode because assert has no effect when NDEBUG is defined
We get much more descriptive logs in google tests on using EXPECT_LE instead of EXPECT_TRUE(x<y). With EXPECT_LE, the logs will print out the expected and actual value if the test fails. Super helpful for debugging.
On Mac github runners, we noticed timing tests failing because they are running slightly longer than expected. Nuding the thresholds ever so slightly to account for this.
We noticed race condition (specifically on macs) where persistent auth data (in Keystore) isn't deleted before the next test picks up in the suite. If the next test involves a SignIn and if persistent cache already has a valid user logged in, there is no change in auth or id tokens and our expected listeners are not triggered. We could possibly run into this on other platforms too, hence forcefully waiting 200ms after a SignOut for the persistent data to be cleared.
Locale on github linux runners is returning C.UTF-8. Setting an env variable fixes it.
The upper limit for threshold in previous condition was causing issues on mac machines on github runners. It wasn't sustainable to keep increasing the threshold. Using this test condition now which should make sure Sleep is working as expected.
SignOut in a correct manner instead of setting null pointers. If we do not sign out, there could be information in the persistent cache that can prevent a subsequent sign in from happening and cause the tests to run incorrectly (saw errors when running on github mac runners)
b113df0 to
b97ffdd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.